Add CodeMirror extension for Operations#9245
Merged
franknoirot merged 7 commits intomainfrom Feb 13, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
37e7ec6 to
bd40a94
Compare
bd40a94 to
7230a7e
Compare
jacebrowning
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #8885, stacked on top of #9237 and very much in the same vein. Registers a StateField and StateEffect pair to keep the AST in sync within the CodeMirror state. Broken out from #9190 so we can take safer baby steps towards that.
Another aspect I'm excited about for this one is that once we have a reliable binding between operations and code source ranges right within the CodeMirror editor I can basically get rid of
featureTreeMachine. Most of that state machine is dedicated to rigamarole surrounding getting the current editor, opening it, and updating its selection, etc.This is a refactor only, and should not be felt by users. For now this extension is unused, but it allows us to test the validity of this state, and move towards making all editor-related state being tracked within the
EditorViewclass itself.